allow artifact string macro to take an explicit path to the artifact file #46755
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
staticfloat
approved these changes
Sep 14, 2022
Member
staticfloat
left a comment
staticfloat
left a comment
There was a problem hiding this comment.
Can we call the value “artifacts_toml_path” or something like that, to avoid confusion with the actual path of the artifact we want to return?
vtjnash
reviewed
Sep 14, 2022
can be used by JLLs to avoid scour throgh the file system for the Artifacts.toml when it already knows where it is
We must provide the `platform` argument here before we provide the `artifacts_toml_path` argument.
staticfloat
force-pushed
the
kc/artifact_macro_explicit_path
branch
from
4013bc5 to
02f3df8
Compare
Member
Author
|
@staticfloat, good to go? |
KristofferC
commented
Oct 10, 2022
| find_artifacts_toml(srcfile) | ||
| else | ||
| artifacts_toml_path | ||
| eval(artifacts_toml_path) |
Member
Author
There was a problem hiding this comment.
Did you try this @staticfloat? It seems to error for me:
In [3]: using Vulkan_Headers_jll
[ Info: Precompiling Vulkan_Headers_jll [8d446b21-f3ad-5576-a034-752265b9b6f9]
ERROR: LoadError: Evaluation into the closed module `Artifacts` breaks incremental compilation because the side effects will not be permanent. This is likely due to some other module mutating `Artifacts` with `eval` during precompilation - don't do this.
Stacktrace:
[1] eval
@ ./boot.jl:370 [inlined]
[2] eval(x::String)
@ Artifacts ~/julia/usr/share/julia/stdlib/v1.9/Artifacts/src/Artifacts.jl:3
[3] var"@artifact_str"(__source__::LineNumberNode, __module__::Module, name::Any, platform::Any, artifacts_toml_path::Any)
@ Artifacts ~/julia/usr/share/julia/stdlib/v1.9/Artifacts/src/Artifacts.jl:665
Member
There was a problem hiding this comment.
No, I only tried it with the test set, which doesn't hit this error, apparently. @vtjnash what is the correct fix here? I don't really understand how to properly "get" the value of a string at compile-time I guess.
Member
Author
There was a problem hiding this comment.
What was it that failed before this change? I tried it with JLLWrappers and it seemed to work ok without the eval.
staticfloat
added a commit
that referenced
this pull request
Oct 10, 2022
This causes the eval to be invoked in user scope, rather than in the `Artifacts` module itself. X-ref: #46755 (review)
DilumAluthge
pushed a commit
that referenced
this pull request
Oct 14, 2022
This causes the eval to be invoked in user scope, rather than in the `Artifacts` module itself. X-ref: #46755 (review)
lgoettgens
added a commit
to lgoettgens/julia
that referenced
this pull request
May 31, 2023
…rtifact file (JuliaLang#46755)" This reverts commit 1720a54.
lgoettgens
added a commit
to lgoettgens/julia
that referenced
this pull request
Jun 2, 2023
…rtifact file (JuliaLang#46755)" This reverts commit 1720a54.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
can be used by JLLs to avoid scouring through the file system for the Artifacts.toml when it already knows where it is
JLLWrappers PR at JuliaPackaging/JLLWrappers.jl#45